Thanks guys!
https://codereview.appspot.com/6819104/diff/1/app/views/charm.js File app/views/charm.js (right): https://codereview.appspot.com/6819104/diff/1/app/views/charm.js#newcode90 app/views/charm.js:90: this.fire('navigateTo', { On 2012/11/07 18:12:57, benji wrote: > This doesn't match our normal object literal multi-line format. Perhaps it > should just be a one-liner instead. Done. https://codereview.appspot.com/6819104/diff/1/app/views/charm.js#newcode135 app/views/charm.js:135: self.fire('navigateTo', { On 2012/11/07 18:12:57, benji wrote: > Insert another object literal style nitpick here. Done. https://codereview.appspot.com/6819104/diff/1/app/views/service.js File app/views/service.js (right): https://codereview.appspot.com/6819104/diff/1/app/views/service.js#newcode219 app/views/service.js:219: this.fire('navigateTo', { On 2012/11/07 18:12:57, benji wrote: > object literal style Done. https://codereview.appspot.com/6819104/diff/1/app/views/service.js#newcode866 app/views/service.js:866: this.fire('navigateTo', { On 2012/11/07 18:12:57, benji wrote: > object literal style Done. https://codereview.appspot.com/6819104/diff/1/app/views/unit.js File app/views/unit.js (right): https://codereview.appspot.com/6819104/diff/1/app/views/unit.js#newcode211 app/views/unit.js:211: this.fire('navigateTo', { On 2012/11/07 18:12:57, benji wrote: > object literal style Done. https://codereview.appspot.com/6819104/ -- https://code.launchpad.net/~tveronezi/juju-gui/generic-show-view-event/+merge/133247 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~tveronezi/juju-gui/generic-show-view-event into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
