Hey Nicola. I'm going to try out the charm now, but I had a few preliminary comments from the code alone.
Beyond what I mention in-line, and as I mentioned on IRC, I think you need to expose port 443 now, rather than 80. I'll give the charm a try now and report back. https://codereview.appspot.com/6940084/diff/1/README.md File README.md (right): https://codereview.appspot.com/6940084/diff/1/README.md#newcode60 README.md:60: - 80/tcp I assume this is 443 now? https://codereview.appspot.com/6940084/diff/1/hooks/utils.py File hooks/utils.py (right): https://codereview.appspot.com/6940084/diff/1/hooks/utils.py#newcode227 hooks/utils.py:227: if not (os.path.exists(pem_path) and os.path.exists(pem_path)): I suspect you meant key_path for one of those. If only one of the files is there, is it still the right behavior to create both files, overwriting them? I don't know the answer, just asking. https://codereview.appspot.com/6940084/ -- https://code.launchpad.net/~teknico/charms/precise/juju-gui/serve-via-https/+merge/140511 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~teknico/charms/precise/juju-gui/serve-via-https into lp:~juju-gui/charms/precise/juju-gui/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
