The proposal to merge lp:~frankban/charms/precise/juju-gui/bug-1088618-serve-releases into lp:~juju-gui/charms/precise/juju-gui/trunk has been updated.
Description changed to: Updated the charm to serve Juju GUI releases. I had a pre-implementation call with Gary and some really useful help from Brad. Details: Replaced the juju-gui-branch config option with a new juju-gui-source one: here you can specify where to deploy the GUI from (stable, trunk, a branch, a specific version of stable/trunk). Added a bunch of functions in utils.py: they help parsing the juju-gui-source option, retrieving the URL of a release, etc. Added tests for the utility functions above. Changed the fetch/build function in utils.py, so that now a release tarball is always used to install the GUI. It can be downloaded from Launchpad or created using "make distfile" from a juju-gui checkout. Also reorganized the fetch/build code: separated each of the fetch/build functions into two different functions (one for the GUI, one for the API). Updated the install and the config-changed hooks to conform to the new fetch/setup functions (mentioned above). Updated the config-changed hook to reflect changes to the options, install hook and utils.py. Added one functional test specific to deploying from a branch. The other tests now default to the latest stable release. Created and uploaded Juju GUI trunk/stable releases. Updated the stop hook: now the function in utils.py is called with the argument it expects. Overall code lint and clean up. All those changes result in a big diff (~820 lines), sorry about that. https://codereview.appspot.com/6977043/ For more details, see: https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1088618-serve-releases/+merge/140745 -- https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1088618-serve-releases/+merge/140745 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/charms/precise/juju-gui/bug-1088618-serve-releases into lp:~juju-gui/charms/precise/juju-gui/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
