Reviewers: mp+141197_code.launchpad.net, Message: Please take a look.
Description: Make tests more reliable. - Disable async loading for yui to ensure app code is loaded before tests. - Yank yui loader closures around tests, this is an anti-pattern. - Any test file can be run in isolation now. - Re-order test loading into alphabetical order to detect/correct collisions. - Enable using firefox for tests via test loader fix. - WIP enable using phantomjs for running tests on cli. - Make topology-mega.js more foregiving on its (there's a event subscription leak here.) - Fix event subscription leak in charm-panel code. https://code.launchpad.net/~hazmat/juju-gui/reliable-test/+merge/141197 (do not edit description out of merge proposal) Please review this at https://codereview.appspot.com/7003054/ Affected files: A [revision details] M app/app.js M app/modules-debug.js M app/templates/overview.handlebars M app/views/charm-panel.js M app/views/environment.js M app/views/topology/mega.js M app/views/topology/panzoom.js M app/views/utils.js M package.json M test/index.html M test/test_app.js M test/test_app_hotkeys.js M test/test_d3_components.js M test/test_notifications.js M test/test_notifier_widget.js -- https://code.launchpad.net/~hazmat/juju-gui/reliable-test/+merge/141197 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~hazmat/juju-gui/reliable-test into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
