On Tue, Dec 23, 2008 at 9:18 PM, Kalman Noel <[email protected]> wrote: > > Jean-Philippe Bernardy wrote: >>> Tue Dec 23 16:22:47 CET 2008 Kalman Noel <[email protected]> >>> implement reloading >> >> Reloadng works (or last time I checked)... what does this means exactly? > > [I'm afraid this answer got a little lengthy...] > > Here's my conception: Currently the code that is responsible for > reloading executes what it gets from getProgName. (It does this contrary > to the comment that says it would execute projectName.) This name may be > either of > > * yi (if -fhacking or if there is no customized yi) > * yi-ARCH-OS (if this is a customized yi) > > In either case, getProgName returns only the basename, not the full path > to the executable. > > yi-ARCH-OS is typically not in PATH, so on reloading I get an error > about it not being found. In -fhacking mode reloading probably pretends > to work and executes the yi that is installed in PATH. I'm not sure what > behaviour you are referring to when you say that reloading works ;-) > > (We were discussing this on IRC, but with slightly deriving opinions on > what reloading should do exactly. This patch changes the behaviour to > always execute a yi that is in PATH, that is, it acts according to the > source code comment "Attempt to restart Project by executing the program > @projectName@". I'm neglecting -fhacking for the purposes of reloading, > i.e.)
That seems good to me. I'l >>> , introduce some bugs >> >> I guess this means we should wait before applying? > > That depends on whether this patch improves or worsens reloading, in > your eyes :) The introduced bug that I'm referring to is the following: > With the changed reloading implementation, if I reload and later quit > yi, I get a messed-up terminal state. I suppose that executing one yi on > top of another prevents Vty from restoring the initial terminal state. > But even if that's right, I'm not sure how to properly fix it. That's > why I added a FIXME in Yi.Boot. > Merry christmas to you too ;) -- JP --~--~---------~--~----~------------~-------~--~----~ Yi development mailing list [email protected] http://groups.google.com/group/yi-devel -~----------~----~----~----~------~----~------~--~---
