On Fri, May 22, 2009 at 10:26 AM, Colin McQuillan <[email protected]> wrote: > Attached is my latest code - it can handle terminal resizing, split > windows so should be quite usable. Can anyone see any problems except > for the handling of wrapped lines?
This patch looks great. The replacement of "prepareAction" with "layout" is a good step in adding a controller layer. The EditorM action for layout is consistent with a window controller refresh but as a editor action. The editor, I think, can be considered a view controller as well. The implementation of scrollB clearly communicates the process of the view being scrolled and the insert mark being moved to be in view. Which was a bit disconnected with the pointDrive approach. One issue is that the pango frontend still tries to use prepareAction. Just for completeness I'll test it out today without using pango. Assuming no huge issues are found, pango can be updated, and nobody takes issue apply it should be fine IMO. Cheers, Corey --~--~---------~--~----~------------~-------~--~----~ Yi development mailing list [email protected] http://groups.google.com/group/yi-devel -~----------~----~----~----~------~----~------~--~---
