On Sep 18, 2:31 am, Jean-Philippe Bernardy <berna...@chalmers.se> wrote: > On Sat, Sep 18, 2010 at 6:36 AM, Jeremy Wall <jw...@google.com> wrote: > > Since YI snaps the window to center on the point scrolling off the > > screen is a jarring experience. > > > I've put together a couple patches that make scrolling work more > > reasonable (in my opinion) by only moving the window the minimum > > distance to keep the point visible. (one line up or down). > > I can see two reasons for the current behaviour: > > 1. It used to be that scrolling was slower than normal movement. > Scrolling by a chunk at a time makes the editior more responsive. > 2. When jumping about in the file (say using search), you want the > found occurrence centered, not at the bottom/top.
My code would not center the found occurence. I'm not sure how you could distinguish between scrolling while searching and scrolling during normal movement. The same snapping code is used for both. Personally I would prefer to optimize for the scrolling case not the searching case but I'm just one guy scratching his own itch :-) I won't feel hurt if everyone else disagrees. > > How does your code deal with this issues? > > > I've sent two patches to this list but I have no way of knowing if > > theyv'e been seen yet since the list is moderated. > > They do not appear to have reached the list. > I believe that they would go through now that one of your messages has > been accepted. Should I resend? or wait a bit more? > > > I'd appreciate any comments on the code. It's my first "real" haskell > > code. It seems to work in the vty UI but I think the pango UI would > > need to be patched as well. I'd be hapy to tackle that one as well but > > I can't get pango to launch on my macbook so testing changes would be > > difficult. > > The pango frontend is "experimental", so I would not worry too much about it. > > Cheers, > JP. -- Yi development mailing list yi-devel@googlegroups.com http://groups.google.com/group/yi-devel
