Right, I agree with that. Then the patch is fine, but please send it to the
correct list: [email protected]

Alex


On Thu, 13 Aug 2020 at 00:19, Chandana Kalluri <[email protected]> wrote:

> I agree its possible for virgl and qemu to not be tested with other libgl
> providers other than mesa.
>
> But I also think mesa shouldn’t be hardcoded within the two recipes and
> should use virtual/libgl so as to provide the users with the flexibility to
> specify something other than mesa.
>
> If the recipes fail for using something other than mesa, it’s still the
> users choice .
>
>
>
> Thanks,
>
> Chandana
>
>
>
> *From:* Alexander Kanavin <[email protected]>
> *Sent:* Wednesday, August 12, 2020 2:32 PM
> *To:* Chandana Kalluri <[email protected]>
> *Cc:* [email protected]; Chandana Kalluri <[email protected]>
> *Subject:* Re: [yocto] [poky][master][PATCH] qemu.inc: Use virtual/libgl
> instead of mesa
>
>
>
> Virgl is not verified with anything else than mesa, and will almost
> certainly fail. And so does qemu.
>
>
>
> I think you should rather remove glx and virglrenderer from qemu
> PACKAGECONFIG, so that mesa is not pulled in at all.
>
>
>
> Alex
>
>
>
> On Wed, 12 Aug 2020 at 23:02, Chandana kalluri <[email protected]>
> wrote:
>
> If there are multiple providers of virtual/libgl and mesa is not the
> default
> provider, the recipe compilation fails.  Use virtual/libgl to pick the
> default
> provider.
>
> Signed-off-by: Sai Hari Chandana Kalluri <[email protected]>
> ---
>  meta/recipes-devtools/qemu/qemu.inc                        | 2 +-
>  meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/qemu/qemu.inc
> b/meta/recipes-devtools/qemu/qemu.inc
> index b1c822b..dada4b8 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -163,7 +163,7 @@ PACKAGECONFIG[nettle] =
> "--enable-nettle,--disable-nettle,nettle"
>  PACKAGECONFIG[libusb] = "--enable-libusb,--disable-libusb,libusb1"
>  PACKAGECONFIG[fdt] = "--enable-fdt,--disable-fdt,dtc"
>  PACKAGECONFIG[alsa] = "--audio-drv-list='oss alsa',,alsa-lib"
> -PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,mesa"
> +PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/libgl"
>  PACKAGECONFIG[lzo] = "--enable-lzo,--disable-lzo,lzo"
>  PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl"
>  PACKAGECONFIG[gnutls] = "--enable-gnutls,--disable-gnutls,gnutls"
> diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb
> b/meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb
> index 29b1262..5282119 100644
> --- a/meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb
> +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_0.8.2.bb
> @@ -8,7 +8,7 @@ HOMEPAGE = "https://virgil3d.github.io/";
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=c81c08eeefd9418fca8f88309a76db10"
>
> -DEPENDS = "libdrm mesa libepoxy"
> +DEPENDS = "libdrm virtual/libgl libepoxy"
>  SRCREV = "7d204f3927be65fb3365dce01dbcd04d447a4985"
>  SRC_URI = "git://anongit.freedesktop.org/virglrenderer \
>
> file://0001-gallium-Expand-libc-check-to-be-platform-OS-check.patch \
> --
> 2.7.4
>
> 
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#50272): https://lists.yoctoproject.org/g/yocto/message/50272
Mute This Topic: https://lists.yoctoproject.org/mt/76155719/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to