Hey,

I figured to squeeze in a test and it seems that this is solved in Dunfell, at 
least I can’t trigger it even when trying and the folder structure used in the 
work directory has changed -> No issues there I guess.

For Zeus: I’ve checked 
https://git.yoctoproject.org/cgit/cgit.cgi/poky/log/?h=zeus and it seems that 
there are no new commits. From https://wiki.yoctoproject.org/wiki/Releases zeus 
is in the Community phase.
Does this mean no new commits -> Add it to some kind of “known issues” page? Or 
does it make sense to provide a patch for the zeus branch?

Best regards, Olli


Von: Jean-Marie Lemetayer <[email protected]>
Gesendet: Freitag, 22. Januar 2021 11:31
An: Westermann, Oliver <[email protected]>
Cc: [email protected]
Betreff: [EXTERNAL] Re: [yocto] NPM Fetcher & License collection in Yocto Zeus

Hi Olivier,

Thanks for your implication :)

I think the modification you want to make resides in the npm class file:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/classes/npm.bbclass?h=zeus<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.yoctoproject.org%2Fcgit%2Fcgit.cgi%2Fpoky%2Ftree%2Fmeta%2Fclasses%2Fnpm.bbclass%3Fh%3Dzeus&data=04%7C01%7Coliver.westermann%40cognex.com%7C0c9d1eac73b84cbdf12d08d8bec0c59b%7Cc12007a4882b4381b05ab783431570c7%7C1%7C0%7C637469083067919634%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jpXCTmSGmw0aixiaaMpRVmKRQeLwOS3cNRUaWLB7jZY%3D&reserved=0>

But, starting with dunfell, the npm related mechanism have been reworked and 
also the npm class:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/classes/npm.bbclass?h=dunfell<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.yoctoproject.org%2Fcgit%2Fcgit.cgi%2Fpoky%2Ftree%2Fmeta%2Fclasses%2Fnpm.bbclass%3Fh%3Ddunfell&data=04%7C01%7Coliver.westermann%40cognex.com%7C0c9d1eac73b84cbdf12d08d8bec0c59b%7Cc12007a4882b4381b05ab783431570c7%7C1%7C0%7C637469083067929588%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ALelbwc4s8BfS7gRmQ8RUdNifvftAVJXetPz%2BamYSoE%3D&reserved=0>

Is it possible to test if you have the same issue with dunfell ?

Best Regards,
Jean-Marie

On Fri, Jan 22, 2021 at 10:00 AM Oliver Westermann 
<[email protected]<mailto:[email protected]>> wrote:
Hey,

We’ve upgraded to zeus some time ago and also updated some of our recipes 
around node-red and it’s nodes. Before I created my own class to easily fetch 
several nodes, now we used devtool to create those recipes. In zeus, this 
happens using the npm:// fetcher.

This worked fine, but we sometimes had QA errors, hard to reproduce. Sometimes 
on some peoples PC, the license files were missing when do_populate_lic was 
running.

ERROR: node-red-contrib-socketio-1.0.7-r0 do_populate_lic: QA Issue: 
node-red-contrib-socketio: LIC_FILES_CHKSUM points to an invalid file: 
/data/workspace/yocto-build/build/cognex-myna/tmp/work/aarch64-poky-linux/node-red-contrib-socketio/1.0.7-r0/npmpkg/node_modules/socket.io/node_modules/@types/cookie/LICENSE<https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsocket.io%2Fnode_modules%2F%40types%2Fcookie%2FLICENSE&data=04%7C01%7Coliver.westermann%40cognex.com%7C0c9d1eac73b84cbdf12d08d8bec0c59b%7Cc12007a4882b4381b05ab783431570c7%7C1%7C0%7C637469083067929588%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=p%2BJKkpqkeGPSjjmnyIgoP2u9m2o3jSLR4ikoX5gJfTQ%3D&reserved=0>
 [license-checksum]

Turned out that do_unpack would download the dependencies of the 
node-red-module (so in the example above, node-red-contrib-socketio depends on 
socket.io<https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsocket.io%2F&data=04%7C01%7Coliver.westermann%40cognex.com%7C0c9d1eac73b84cbdf12d08d8bec0c59b%7Cc12007a4882b4381b05ab783431570c7%7C1%7C0%7C637469083067939545%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nf5kKNPRlKZBiMPntp7upXBx0URJXdp4GNlrZEYrLds%3D&reserved=0>),
 but do_install would package those away/clean them up.
Since they go into the resulting package, we still have to list those licenses, 
so I fixed it by adding

do_install[depends] += "${PN}:do_populate_lic"

to my packages to fix the order.

However I would like to fix this upstream, but couldn't find the correct source 
location to add this dependency. Can sb help me figure this out as I would like 
to contribute 😉

Best regards, Olli


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#52083): https://lists.yoctoproject.org/g/yocto/message/52083
Mute This Topic: https://lists.yoctoproject.org/mt/80026361/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to