On Fri, Jun 4, 2021 at 8:37 AM Bruce Ashfield via
lists.yoctoproject.org
<[email protected]> wrote:
>
> On Fri, Jun 4, 2021 at 8:27 AM Bruce Ashfield <[email protected]> 
> wrote:
> >
> > On Thu, Jun 3, 2021 at 11:35 PM Kai <[email protected]> wrote:
> > >
> > > On 6/4/21 11:22 AM, Bruce Ashfield wrote:
> > > > On Thu, Jun 3, 2021 at 11:06 PM <[email protected]> wrote:
> > > >> From: Kai Kang <[email protected]>
> > > >>
> > > >> Replace hardknott with honister in layer.conf which aligns with
> > > >> oe-core.
> > > >>
> > > > I had added this back in April, but apparently didn't push the change.
> > > >
> > > > I also noticed that I've been updating the wrong branch with 
> > > > compatibility.
> > > >
> > > > That should all be fixed now.
> > >
> > > Hi Bruce,
> > >
> > > Thanks. I have seen your commits.
> > >
> > > But 3 items in LAYERSERIES_COMPAT_realtime will cause layer index show
> > > warning:
> > >
> > >    WARNING: YPCompatibleVersion.name: dunfell gatesgarth hardknott:
> > > length 28 exceeds maximum (25), truncating
> > >
> > > Could we only keep the latest LAYERSERIES_CORENAMES (honister) in branch
> > > master, please?
> >
> > Nope. It is compatible with those releases, so they need to stay. I
> > see no valid reason to be limited to a certain number of characters.
> >
> > >
> > > Or it set in oe-core's layer.conf:
> > >
> > > LAYERSERIES_CORENAMES = "hardknott honister"
> > >
> > > we just align with it to keep the latest 2, please?
> >
> > That is just as arbitrary, I'll keep it as-is.
>
> I took a quick look, is this warning coming from the layer index ?
> That would be important information to convey when sending changes
> like this.

Apologies on this, I see in the follow up email you did mention the
layerindex .. I read completely over that, and had to search up the
warning myself. (my fault, not yours).

>
> That being said, it is a longer fix to get that warning changed, and
> I'd rather not break the index, so I dropped to only the last two
> releases.
>
> But I do recommend that the layer index be changed (if that is the
> cause of the warning), since we shouldn't be adapting to the index ..
> it should be adapting to layers.

This point still stands though :D

Bruce

>
> Bruce
>
> >
> > Bruce
> >
> > >
> > > Regards,
> > > Kai
> > >
> > > >
> > > > Bruce
> > > >
> > > >> Signed-off-by: Kai Kang <[email protected]>
> > > >> ---
> > > >>   conf/layer.conf | 2 +-
> > > >>   1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>
> > > >> diff --git a/conf/layer.conf b/conf/layer.conf
> > > >> index 007f578..8ae67ba 100644
> > > >> --- a/conf/layer.conf
> > > >> +++ b/conf/layer.conf
> > > >> @@ -15,6 +15,6 @@ BBFILE_PRIORITY_realtime = "5"
> > > >>   # This should only be incremented on significant changes that will
> > > >>   # cause compatibility issues with other layers
> > > >>   LAYERVERSION_realtime = "1"
> > > >> -LAYERSERIES_COMPAT_realtime = "hardknott"
> > > >> +LAYERSERIES_COMPAT_realtime = "honister"
> > > >>   LAYERDEPENDS_realtime = "core openembedded-layer"
> > > >>   LAYERRECOMMENDS_realtime = "meta-realtime-dl (= 3.2)"
> > > >> --
> > > >> 2.17.1
> > > >>
> > > >
> > >
> > > --
> > > Kai Kang
> > > Wind River Linux
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#53754): https://lists.yoctoproject.org/g/yocto/message/53754
Mute This Topic: https://lists.yoctoproject.org/mt/83300536/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to