On Mon 5. Jun 2023 at 23.46, Konstantin Ryabitsev <
[email protected]> wrote:

> On Sat, Jun 03, 2023 at 03:25:59PM +0200, Alexander Kanavin wrote:
> > AUH attaches not just the patch (if it was possible to produce), but
> > also buildhistory and build failure logs (if something failed). It
> > also provides a bit of explanation/context/apply-resend instructions
> > in the email text. We can certainly consider options, I'm just not
> > sure how to arrange all that if patches are sent directly as emails.
>
> It's actually pretty straightforward. Instead of attaching the patch to the
> message, place it under the scissors line "-- >8 --".
>
> E.g. if we take this message:
>
>
> https://lore.kernel.org/openembedded-core/010101887b289125-ddc413a5-24e2-4458-a329-e719e936d0e6-000...@us-west-2.amazonses.com/
>
> Make the body of the message as follows:
>
>         ... (skipped) ...
>         Please review the attached files for further information and
> build/update failures.
>         Any problem please file a bug at
> https://bugzilla.yoctoproject.org/enter_bug.cgi?product=Automated%20Update%20Handler
>
>         Regards,
>         The Upgrade Helper
>
>         -- >8 --
>         From e302d4d1d5eb9f8377ddcfac58e46b0d787f1e88 Mon Sep 17 00:00:00
> 2001
>         From: Upgrade Helper <[email protected]>
>         Date: Fri, 2 Jun 2023 05:09:50 +0000
>         Subject: [PATCH] at-spi2-core: upgrade 2.48.0 -> 2.48.3
>
>         ---
>          .../atk/{at-spi2-core_2.48.0.bb => at-spi2-core_2.48.3.bb}
> | 2 +-
>          1 file changed, 1 insertion(+), 1 deletion(-)
>          rename meta/recipes-support/atk/{at-spi2-core_2.48.0.bb =>
> at-spi2-core_2.48.3.bb} (95%)
>
>         diff --git a/meta/recipes-support/atk/at-spi2-core_2.48.0.bb
> b/meta/recipes-support/atk/at-spi2-core_2.48.3.bb
>         ... (skipped) ...
>
> This should make it possible for someone to use this patch directly without
> having to first save the attachment.
>
> Here's more info about the scissors line:
>
> https://git-scm.com/docs/git-mailinfo#Documentation/git-mailinfo.txt---scissors
>
> Hope this helps.


Thanks, that seems reasonable, but is then it still ok to attach additional
build artifacts (logs etc) to the message? Will the tools first discard the
attachments, take the message body, then apply the scissors to get the
patch out?

>
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#60191): https://lists.yoctoproject.org/g/yocto/message/60191
Mute This Topic: https://lists.yoctoproject.org/mt/99297388/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to