On 11-09-08 06:05 PM, Saxena, Rahul wrote:
Cover letter for separating 10/100 LAN feature from 1G and 10G.
Typically a machine does not need both of 10/100 and 1G/10G drivers.

The change looks fine, and I'd agree that this is a useful split.
BUT (there's always a but), there are a set of boards that are currently
including the e1xxxx feature that would currently be getting the e100,
and they'll no longer have it.

./bsp/common-pc/common-pc.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/fri2/fri2.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/fishriver/fishriver.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/romley/romley.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/emenlow/emenlow.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/crownbay/crownbay.scc:include features/intel-e1xxxx/intel-e1xxxx.scc
./bsp/common-pc-64/common-pc-64.scc:include features/intel-e1xxxx/intel-e1xxxx.scc

In particular the common-pc really does want that config (for qemu).
So we should do the split, but also update all those boards to include
your new feature as part of this change.

Can you try and resend with that addition ? You don't need to built/boot,
just make the touches to the files listed above and I can take care of
the rest.

Bruce


Signed-off-by: Rahul Saxena<[email protected]>

Rahul Saxena (2):

Remove 10/100 LAN support. 10/100 LAN will be configured by seperate

files

Added seperate feature for 10/100 LAN support

.../features/intel-e1xxxx/intel-e100.cfg | 2 ++

.../features/intel-e1xxxx/intel-e100.scc | 1 +

.../features/intel-e1xxxx/intel-e1xxxx.cfg | 1 -

3 files changed, 3 insertions(+), 1 deletions(-)

create mode 100644
meta/cfg/kernel-cache/features/intel-e1xxxx/intel-e100.cfg

create mode 100644
meta/cfg/kernel-cache/features/intel-e1xxxx/intel-e100.scc



_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Reply via email to