On 05/04/2012 09:28 AM, Tom Zanussi wrote: > On Fri, 2012-05-04 at 09:16 -0700, Darren Hart wrote: >> >> On 05/02/2012 08:35 PM, [email protected] wrote: >>> From: Tom Zanussi <[email protected]> >>> >>> Add a feature to enable 'base' support for USB, mainly to be included >>> by derived features such as ehch, xhci, etc. >> >> This seems overly granular in my opinion. I think I would just include >> the two required options in each of the *hci features. >> > > Really? This seems to me a perfect use case for taking advantage of the > 'reusibality' conf fragments offer. There would be four of these, that > alone would seem to justify using a 'subroutine', but there could be > more in the future, and if so, this fragment would be readily available. >
I agree in principle, but feel the two lines of obvious requirements aren't worth it. > i.e. I don't see any reason to 'inline' these... I think "the line" is obviously a subjective one. And since you are the one that put in the time to prepare the meta-data, I don't feel strongly enough about it to argue the point. So I won't object to them going in as is. -- Darren > > Tom > >> -- >> Darren >> >>> >>> Signed-off-by: Tom Zanussi <[email protected]> >>> --- >>> meta/cfg/kernel-cache/features/usb/host/base.cfg | 3 +++ >>> meta/cfg/kernel-cache/features/usb/host/base.scc | 4 ++++ >>> 2 files changed, 7 insertions(+), 0 deletions(-) >>> create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg >>> create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc >>> >>> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.cfg >>> b/meta/cfg/kernel-cache/features/usb/host/base.cfg >>> new file mode 100644 >>> index 0000000..dec6a47 >>> --- /dev/null >>> +++ b/meta/cfg/kernel-cache/features/usb/host/base.cfg >>> @@ -0,0 +1,3 @@ >>> +CONFIG_USB_SUPPORT=y >>> +CONFIG_USB=y >>> + >>> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.scc >>> b/meta/cfg/kernel-cache/features/usb/host/base.scc >>> new file mode 100644 >>> index 0000000..3c93475 >>> --- /dev/null >>> +++ b/meta/cfg/kernel-cache/features/usb/host/base.scc >>> @@ -0,0 +1,4 @@ >>> +define KFEATURE_DESCRIPTION "Enable core options for USB support" >>> +define KFEATURE_COMPATIBILITY board >>> + >>> +kconf hardware base.cfg >> > > -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel _______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto
