On 05/09/2012 11:50 AM, Tom Zanussi wrote: > On Wed, 2012-05-09 at 11:14 -0700, Darren Hart wrote: >> >> On 05/08/2012 02:37 PM, [email protected] wrote: >>> From: Tom Zanussi <[email protected]> >>> >>> The boot-live options are already included via common-pc-64 so remove >>> the associated config settings from the top-level feature. >> >> The appropriate place for these in my opinion is in BSP-standard.scc and >> BSP-preempt_rt.scc. That would be the common-pc-64-standard.scc for >> example in this case. >> >> This should not be part of a machine config fragment as it is more of a >> ktype policy item than it is a bsp item. I expect "standard" kernels to >> be able to do live boot, but "tiny" images should not. >> > > Right, this patch does actually remove it from the machine fragment for > the BSP, but I take your point - I was noticing when adding the usb > features that there are plenty of opportunities for cleanup of the > common-pc-* fragments, and it probably does make sense to add > 'policy'-related features to the -standard/preempt-rt containers in > general, though not just for 'tiny' since I doubt anyone would ever want > a 'tiny' jasperforest BSP. >
Right, tiny was just an example. > So, agreed in principal, but that's a separate task from this patchset. That's fine. I can do it as well when I update the others. Nice to do general changes like that at once so the BSPs remain consistent. -- Darren > > Tom > >> Note that usb-mass-storage.scc should also be added to the standard and >> preempt-rt scc files per BSP. I've done the former and am currently >> working through the latter with my BSPs. >> >> -- >> Darren >> >>> >>> Signed-off-by: Tom Zanussi <[email protected]> >>> --- >>> .../kernel-cache/bsp/jasperforest/jasperforest.cfg | 7 ------- >>> 1 files changed, 0 insertions(+), 7 deletions(-) >>> >>> diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg >>> b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg >>> index 0a81a19..e2310a5 100644 >>> --- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg >>> +++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg >>> @@ -34,13 +34,6 @@ CONFIG_PM=y >>> CONFIG_ACPI=y >>> CONFIG_INPUT=y >>> >>> -# Needed for booting (and using) USB memory sticks >>> -CONFIG_BLK_DEV_LOOP=y >>> -CONFIG_NLS_CODEPAGE_437=y >>> -CONFIG_NLS_ISO8859_1=y >>> - >>> -CONFIG_RD_GZIP=y >>> - >>> # NUMA support >>> CONFIG_NUMA=y >>> CONFIG_X86_64_ACPI_NUMA=y >> > > -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel _______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto
