From: Daniel Stone [mailto:dan...@fooishbar.org] Sent: Wednesday, December 05, 2012 9:48 PM To: Martin Jansa Cc: Kamble, Nitin A; yocto@yoctoproject.org Subject: Re: [yocto] [PATCH 0/1] Misc: detect trailing space in the patches
Hi, On 6 December 2012 15:23, Martin Jansa <martin.ja...@gmail.com<mailto:martin.ja...@gmail.com>> wrote: Can you add also detection of mixed whitespace? E.g. tab followed by space in multilinear indentation? Only as warning. Thanks These checks can generate infuriating false positives when your patch modifies upstream code which has trailing or mixed whitespace in either context or removal lines; in this case, removing a line with trailing whitespace and replacing it with one which doesn't would generate a warning. Mixed whitespace is also part of some coding styles, notably the kernel's. Cheers, Daniel This code checks for the trialing whitespace only in the lines added by the patches. The context lines or removed lines are not checked. It is easy to check for mixed whitespace also, but before doing that I would like to know the final decision about it, as I see some objection to it too. Thanks, Nitin
_______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
