Hi,
On 07/03/2013 04:38 PM, Behrens, Holger wrote:
Hi,
On 3 July 2013 12:59, Sergey Matyukevich
<[email protected]> wrote:
Hmm... Thanks for comment. It is good idea to take a break and to see the
forest for the trees. Here is the second patch revision.
Connman init scripts are now installed only when 'sysvinit' feature is
enabled in DISTRO_FEATURES: commit
7c8160ccbe17d6e10bd7a09b91843182a89b9055
in
poky. No need to remove them in bbappend: they are not installed for
'systemd'-enabled
systems and they are needed for 'sysvinit'-enabled systems.
Signed-off-by: Sergey Matyukevich<[email protected]>
---
recipes-connectivity/connman/connman_1.15.bbappend | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/recipes-connectivity/connman/connman_1.15.bbappend
b/recipes-connectivity/connman/connman_1.15.bbappend
index cda612b..83e4b51 100644
--- a/recipes-connectivity/connman/connman_1.15.bbappend
+++ b/recipes-connectivity/connman/connman_1.15.bbappend
@@ -2,8 +2,3 @@ PRINC := "${@int(PRINC) + 2}"
INITSCRIPT_NAME = ""
INITSCRIPT_PARAMS = ""
-
-do_install_append() {
- # Remove init scripts
- rm -r ${D}${sysconfdir}/init.d
-}
--
1.7.2.5
In that case, you can delete INITSCRIPT_NAME and INITSCRIPT_PARAMS too
surely. Then all you're left is the PRINC, so you can delete that if
you don't care/are using the PR service, or delete that bbappend when
connman 1.16 is integrated.
I agree that we could now start with the clean-up of the meta-ivi layer, given the fact that
systemd is now supported by oe-core. Which makes this .bbappend obsolete. And so agree with Ross
to "delete that bbappend when connman 1.16 is integrated". I created a card [1] and
added it to the "Next Up" stack in Trello, so that we don't forget.
Regards,
Holger
[1] https://trello.com/c/bmWpT6lU
Does it make sense to fix the current connman bbappend which is going to
be in use for a while ? In its current state it affects distros which
enable 'systemd' feature and disable 'sysvinit'. One of the following
two options can be chosen. The first one was finalized in this thread:
diff --git a/recipes-connectivity/connman/connman_1.15.bbappend
b/recipes-connectivity/connman/connman_1.15.bbappend
index cda612b..f1deaf2 100644
--- a/recipes-connectivity/connman/connman_1.15.bbappend
+++ b/recipes-connectivity/connman/connman_1.15.bbappend
@@ -1,9 +1 @@
PRINC := "${@int(PRINC) + 2}"
-
-INITSCRIPT_NAME = ""
-INITSCRIPT_PARAMS = ""
-
-do_install_append() {
- # Remove init scripts
- rm -r ${D}${sysconfdir}/init.d
-}
There is also another [minimalistic and failsafe] option:
diff --git a/recipes-connectivity/connman/connman_1.15.bbappend
b/recipes-connectivity/connman/connman_1.15.bbappend
index cda612b..2e5f355 100644
--- a/recipes-connectivity/connman/connman_1.15.bbappend
+++ b/recipes-connectivity/connman/connman_1.15.bbappend
@@ -5,5 +5,5 @@ INITSCRIPT_PARAMS = ""
do_install_append() {
# Remove init scripts
- rm -r ${D}${sysconfdir}/init.d
+ rm -rf ${D}${sysconfdir}/init.d
}
Thanks,
Sergey
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
