Fixes this warning: WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]
Signed-off-by: Scott Ellis <[email protected]> --- meta/recipes-core/coreutils/coreutils_8.24.bb | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb b/meta/recipes-core/coreutils/coreutils_8.24.bb index f042346..6a09c59 100644 --- a/meta/recipes-core/coreutils/coreutils_8.24.bb +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb @@ -28,14 +28,19 @@ SRC_URI[manpages.sha256sum] = "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc EXTRA_OECONF_class-native = "--without-gmp" EXTRA_OECONF_class-target = "--enable-install-program=arch --libexecdir=${libdir}" -# acl is not a default feature +# acl and xattr are not default features # -PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" +PACKAGECONFIG_class-target ??= "\ + ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \ + ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \ +" + PACKAGECONFIG_class-native ??= "" # with, without, depends, rdepends # PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl," +PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr," # [ df mktemp base64 gets a special treatment and is not included in this bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors dirname du \ -- 2.5.0 "Khem Raj" <[email protected]> said: > >> On Jan 15, 2016, at 7:15 AM, Scott Ellis <[email protected]> wrote: >> >> The 'something' would be 'xattr' >> >> PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr," >> >> What should the default be? >> >> The acl option for coreutils looks in DISTRO_FEATURES. >> >> Should I do the same for this? > > if it depends on some DISTRO_FEATURE then definitely yes. Otherwise define the > packageconfig > and then weakly assign a default with ??= > >> >> "Khem Raj" <[email protected]> said: >> >>> Scott >>> >>> Thanks for patch. You might want to send into to oe-core mailing list. >>> >>>> On Jan 14, 2016, at 6:54 AM, Scott Ellis <[email protected]> wrote: >>>> >>>> Fixes this warning: >>>> >>>> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build >>>> dependency? [build-deps] >>>> >>>> Signed-off-by: Scott Ellis <[email protected]> >>>> --- >>>> meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb >>>> b/meta/recipes-core/coreutils/coreutils_8.24.bb >>>> index f042346..47a25f3 100644 >>>> --- a/meta/recipes-core/coreutils/coreutils_8.24.bb >>>> +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb >>>> @@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"; >>>> LICENSE = "GPLv3+" >>>> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\ >>>> >>>> file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8" >>>> -DEPENDS = "gmp libcap" >>>> +DEPENDS = "attr gmp lib cap” >>> >>> while this fix is good. We can make this into a packageconfig knob >>> >>> PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr," >>> >>>> DEPENDS_class-native = "" >>>> >>>> inherit autotools gettext texinfo >>>> -- >>>> 2.5.0 >>>> >>>> -- >>>> _______________________________________________ >>>> yocto mailing list >>>> [email protected] >>>> https://lists.yoctoproject.org/listinfo/yocto >>> >>> >> >> >> -- >> _______________________________________________ >> yocto mailing list >> [email protected] >> https://lists.yoctoproject.org/listinfo/yocto > > -- _______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto
