Hello Andrei and Paul Thanks for your replies. I will create PR in github.
2017-09-07 2:52 GMT+09:00 Andrei Gherzan <[email protected]>: > On Wed, Sep 6, 2017 at 10:18 AM, Paul Barker <[email protected]> wrote: >> >> On Tue, Sep 5, 2017 at 11:34 PM, Yusuke Mitsuki >> <[email protected]> wrote: >> > functions/variables in this bbappend implemented for only raspberrypi3. >> > But these must be able to used to enabling bluetooth on another >> > raspberrypi that has bluetooth feature such as raspberrypi0-wifi. >> > >> > The simple solution is a duplicating these but it is not good ideas for >> > maintainance. >> > >> > Add functions/variables follows to simplify to enabling bluetooth on >> > another raspberrypi that has bluetooth. >> > - BCM_BT_SOURCES >> > - enable_bcm_bluetooth() >> > - BCM_BT_FIRMWARE >> > - BCM_BT_SERVICE >> > >> > Signed-off-by: Yusuke Mitsuki <[email protected]> >> > --- >> > recipes-connectivity/bluez5/bluez5_%.bbappend | 18 ++++++++++++++---- >> > 1 file changed, 14 insertions(+), 4 deletions(-) >> > >> > diff --git a/recipes-connectivity/bluez5/bluez5_%.bbappend >> > b/recipes-connectivity/bluez5/bluez5_%.bbappend >> > index 956d776..b2fbf22 100644 >> > --- a/recipes-connectivity/bluez5/bluez5_%.bbappend >> > +++ b/recipes-connectivity/bluez5/bluez5_%.bbappend >> > @@ -1,6 +1,6 @@ >> > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" >> > >> > -SRC_URI_append_raspberrypi3 = " \ >> > +BCM_BT_SOURCES = " \ >> > file://BCM43430A1.hcd \ >> > file://0001-bcm43xx-Add-bcm43xx-3wire-variant.patch \ >> > >> > file://0002-bcm43xx-The-UART-speed-must-be-reset-after-the-firmw.patch \ >> > @@ -9,7 +9,7 @@ SRC_URI_append_raspberrypi3 = " \ >> > file://brcm43438.service \ >> > " >> > >> > -do_install_append_raspberrypi3() { >> > +enable_bcm_bluetooth() { >> > install -d ${D}/lib/firmware/brcm/ >> > install -m 0644 ${WORKDIR}/BCM43430A1.hcd >> > ${D}/lib/firmware/brcm/BCM43430A1.hcd >> > >> > @@ -19,8 +19,18 @@ do_install_append_raspberrypi3() { >> > fi >> > } >> > >> > -FILES_${PN}_append_raspberrypi3 = " \ >> > +BCM_BT_FIRMWARE = " \ >> > /lib/firmware/brcm/BCM43430A1.hcd \ >> > " >> > >> > -SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " brcm43438.service" >> > +BCM_BT_SERVICE = " brcm43438.service" >> > + >> > +SRC_URI_append_raspberrypi3 = " ${BCM_BT_SOURCES}" >> > + >> > +do_install_append_raspberrypi3() { >> > + enable_bcm_bluetooth >> > +} >> > + >> > +FILES_${PN}_append_raspberrypi3 = " ${BCM_BT_FIRMWARE}" >> > + >> > +SYSTEMD_SERVICE_${PN}_append_raspberrypi3 = " ${BCM_BT_SERVICE}" >> > -- >> > 2.7.4 >> > >> >> This and the follow up patch look excellent, should be easy to modify >> in the future if we need to. >> >> We have switched to using github pull requests for meta-raspberrypi. >> Could you open a pull request on >> https://github.com/agherzan/meta-raspberrypi with these changes >> please? Let me know if you have any issues doing that. > > > +1 from my side. Thanks for this change. We still try to keep patches > rolling to the mailing list too but the main development now happens through > PRs in github. > > -- > Andrei Gherzan -- _______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto
