On Tue, 2018-06-26 at 16:51 +0800, Aaron Chan wrote:
> Signed-off-by: Aaron Chan <aaron.chun.yew.c...@intel.com>
> ---
>  config.json | 32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)

This patch looks like it might be correct. I say "might" as your commit
message tells me what you did (kind of) but not why.

I say "kind of" as you're using core-image-lsb-sdk and poky-lsb here,
probably for a good reason but you don't say why.

The key thing I need to know is what extra testing this provides that
isn't already covered elsewhere on the autobuilder - why do we need to
spend the time testing this?

Can you resend with a better description of why we need to do this
please?

Cheers,

Richard

> 
-- 
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Reply via email to