> Hello Shyam, Hi Trevor
> Thank you for your contribution! > > I just have 3 small nits with your patch, which I am happy to fix myself > without you needing to send a v2 (if that's okay with you): I'm perfectly fine with it. You can merge them it with your fixes. > 1. I see that there's a mistake in meta-rockchip's README file which I will > fix, the email subject should be prefixed with "[meta-rockchip][PATCH]". > Sorry! I will fix this in the README. > > On Wed 2018-09-12 @ 07:40:04 PM, Shyam Saini wrote: >> This patch adds initial support for the Amarula Vyasa Board. > > 2. I'm going to remove the following second sentence from the commit message. > In 2 years, reading the commit logs regarding future promises/TODOs will > seem funny. The sentence above fully explains this patch. > >> With this patch, we would have working images for vyasa, >> single gpt and wic image support would be added later on. > > >> >> Signed-off-by: Shyam Saini <shyam.sa...@amarulasolutions.com> >> --- >> conf/machine/vyasa-rk3288.conf | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> create mode 100644 conf/machine/vyasa-rk3288.conf >> >> diff --git a/conf/machine/vyasa-rk3288.conf b/conf/machine/vyasa-rk3288.conf >> new file mode 100644 >> index 000000000000..9c634325451e >> --- /dev/null >> +++ b/conf/machine/vyasa-rk3288.conf >> @@ -0,0 +1,14 @@ >> +# Copyright (C) 2018 Amarula Solutions >> +# Released under the MIT license (see COPYING.MIT for the terms) >> + >> +#@TYPE: Machine >> +#@NAME: Amarula Vyasa RK3288 >> +#@DESCRIPTION: Amarula Vyasa is Rockchip RK3288 SOC based Single board >> computer with fully supported opensource software. >> + >> +require conf/machine/include/rk3288.inc >> + >> +KERNEL_IMAGETYPE = "uImage" >> +KERNEL_DEVICETREE = "rk3288-vyasa.dtb" > > 3. I'm going to add a space after += for consistency. > >> +KERNEL_EXTRA_ARGS +="LOADADDR=0x02000000" >> + >> +UBOOT_MACHINE = "vyasa-rk3288_defconfig" >> -- >> 2.11.0 >> > > Once again, thank you for your contribution! Will take care of above mentioned points in future. Thanks a lot for explaining. Cheers, Shyam -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto