Hi lars, I think tools is the proper module for the idl2java tool also. We can create a common package inside tools to incorporate the code that would be shared among all the tools.
How about o.a.y.tools.common? It should be ok to pass a reader, we would anyways know quickly if antlr has a problem. The tools module uses Java 5, so no worries there... - Balaji -----Original Message----- From: Lars Kühne [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 10, 2007 6:59 PM To: yoko-dev@incubator.apache.org Subject: idl preprocessor Hi, some questions regarding the IDL preprocessor I mentioned in YOKO-320: Package name: I would like to create a new package for the IDL preprocessor and be able to later reuse it in an Idl2Java compiler (YOKO-27). However the existing code in o.a.y.tools.processors.idl seems to be specifically targeting WSDL output, so I wonder if o.a.y.tools.processors.idl.preprocessor is a good package for the preprocessor. Should I rather use o.a.y.tools.idlpreprocessor? Is the tools module even the right choice or is tools purely concerned with the IDL<->WSDL bridge? Reader vs. InputStream: The code I have acts as a Reader, not an InputStream. Judging from the Antlr API, this doesn't seem to be a problem, but I'm not sure about escape character processing. Can someone confirm that passing a Reader to Antlr is equivalent to passing an InputStream? Java 5: My existing code uses Java5 features (Generics, StringBuilder, etc.). Is is OK to use Java5 in the tools module? Thanks, Lars
