I don't know if anyone has time to look at this, however...

Currently these are all handled in MasterUI but this shouldn't be necessary. In
any given Yoshimi instance, they can only be used by one caller at a time, and
should be able to be called from anywhere in that instance. Everything they
need is passed in through parameters.

In the cases of Choice and Alert, these are minimally changed in miscGui.cpp
and passed on to Query in MasterUI. They don't change anything, just pass back
an integer representing 'yes', 'no, 'cancel'. They handle their own resize
scaling and position/size remembering, and I don't think they could be improved
much.

The only extra link Filer needs is also into Query, although admittedly most of
the calls to it are in MasterUI too. Again nothing is changed. A string is
passed back either empty, or with a full validated file path. The calling
function then decides what it wants to do with it. This also handles its own
resize scaling and position/size remembering. There *are* improvements I'd like
to make, but it's difficult to see what's going on while it's surrounded by all
the unrelated code.

There is far too much in MasterUI - Yes, I put a lot of it there :(

-- 
Will J Godfrey
https://willgodfrey.bandcamp.com/
http://yoshimi.github.io
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.


_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel

Reply via email to