Am 25.06.21 um 21:07 schrieb Will Godfrey:
In some headers we were still including jack/ringbuffer but this was
only referenced in the midi struct in jackEngine.h and that struct only
called for in jackEngine.cpp
Hi Will,
just cross-checked that also with the "references" feature of my IDE.
Not only the "ringBuf" field is unused, also the "pThread" field in the same
structure. Thus, the only field in this "midi" strucutre, that is actively
initialised and accessed from other code is the "port" field.
Moreover, this structure is private in class JackEngine and it is never
exposed or passed to any other function as such.
Thus we can do a more radical clean-up here: we can remove that structure
altogether and just use a plain field of type jack_port_t
This has the nice side effect that we can also drop the #include <pthread.h>
Expanding a little on that, also the field jack_session_event_t *lastevent
in the Jack-Session support is unused. And in a similar vein, also the
header <semaphore.h> in JackEngine.h and YoshimiLV2Plugin.h is unnecessary.
JackClient doesn't use any semaphores any more, and also YoshimiLV2Plugin
has a private field _midiSem, which is no longer referenced any more.
I just sent you the pull request #143 on Github with these changes
-- Hermann
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
