Am 08.08.21 um 12:55 schrieb Will Godfrey:
so I'll do some torture testing on it in a side branch, ....

One small fixup please. In the light of the discussion about
adding things to some other UI container and then disposing them:

void MasterUI::fillfiler(string type_name) {
  //

...
...
          file::dir2string(tofetch, filerpath, filerext, options);
          filerlist.clear();
          filerscroll->clear();


Shouldn't then the last two lines be better swapped? I.e shouldn't
we better call the clear() on the scroller first, which supposedly
detaches all child elements? As it stands now, the filerlist.clear()
has already deleted those objects, and the filerscroll->clear() might
still touch those zombie objects.

-- Hermann





_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel

Reply via email to