On Tue, 26 Oct 2021 02:20:29 +0200 Ichthyostega <p...@ichthyostega.de> wrote:
>Am 25.10.21 um 20:14 schrieb Will Godfrey: >> So, should we leave these alone, or bring them into general consistency too? >> The value we use for PI goes right back to Zyn 2.2.1 > >It depends on the usage, I'd say. >If Pi is used to compute a fourier transform, e.g. for the PAD-Synth >wavetable, >I'd be extremely cautious. On the other hand, if used for some LFO frequency >thing, chances are that a minute change (by unifying some constants) might >not be audible at all. > >-- Hermann I've been on an archaeological dig :) M_PI first appeared with the introduction of cairo type knobs. This kind of precision is quite pointless in the GUI so that's now just PI Later it appeared in V 1.2.2 subsynth when I ported in the overtones extension from Zyn 2.4.4 (the codebases were still mostly compatible then) https://sourceforge.net/p/yoshimi/code/ci/482d74606a19847f8e528261a60ee1f6795185a9/ This is only used for the extreme roll-offs at 10Hz and 1/2 nyquist so I thought it was pretty safe to change that to PI The only remaining 2 * PI bits seem to be in 3 places of analogFilter.cpp. Everywhere else it's TWOPI. I think it's *probably* safe to change these, but I'll leave them until you've completed the test routine so it's possible to find out if it actually makes a difference or not. -- Will J Godfrey https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song. _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
