On Fri, 3 Dec 2021 16:20:14 +0100 Ichthyostega <p...@ichthyostega.de> wrote:
>>> Am 03.12.21 um 13:13 schrieb Ichthyostega: >>>> Just a guess: maybe Clang is overly picky here, > >Am 03.12.21 um 15:03 schrieb Ichthyostega: >> In our case, in fact we do not need a constexpr (guaranteed >> compile time evaluation), since we're initialising a static variable. >> I added the "constexpr" just to be able to have the code inline and >> in the header, for sake of readability. > >In the end it was not hard to fix. And we don't need to place the >initialiser into a .cpp file, since this is template code, and for >templates, the linker is required to sort out duplicates. Moreover, >it would not even be possible to place it into a *.cpp file, without >explicitly generate all expected template instantiations, which would >kind-of nullify the point of the whole exercise. > >I have sent you a pull request. > >I tested it with clang-12 on Debian/testing Thanks a lot for analysing and resolving this one so quickly. -- Will J Godfrey https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song. _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
