I thought I'd finish off the work on unified presets, and of course found a couple of bugs in the process (now fixed). I'll do a bit more testing, but think it is now complete and actually manages some parts that the GUI routines miss. It is also more thread-safe. Once I'm happy with this I'll change the gui routines to use this code (hence 'unified').
In the process I uncovered an oddity. Once up at part level the gui updates are mostly handled by refresh code, with one glaring exception - the AddSynth voice window. This is always deleted and completely rebuilt even when just looking at a different voice. It would seem to me that it would be better to create all 8 voice windows on part changes, and simply hide the ones that are not currently in view (like we do with 'settings'). When making changes, or just pasting we'd then use a refresh function like elsewhere. It would dramatically simplify the code. Anyone got any thoughts on that? -- Will J Godfrey {apparently now an 'elderly'} https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song. _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel