On 10.08.24 22:05, Will Godfrey wrote:
I've made an interesting discovery (where controls seem to give the wrong
wavshape). Working with the current master, Part 1 effects EQ LP2 only one
band.
The GUI control position is always correctly in sync with the CLI values,
and when the graph has moved the wrong way, reading the CLI control shows it
has set the right value, and this is also reflected in the GUI.
Also when first creating the EQ effect the frequency value is interpreted
wrongly. Setting the control to exactly the same value (from the CLI)
corrects this.
On 11.08.24 17:28, Will Godfrey wrote:
The bit below is a far back as I can go. 'i' is just a straight counter, but
working out what is happening in the filter is beyond me. Someone else needs
to follow up on that. 'resp' is returning the wrong value.
Effects::EQ/calcResponse(float freq) const
Line 365
resp *= filter[i].l->H(freq);
Hi Will,
during my rework of the EQ GUI for the new data connection I also noticed this
issue; basically I can confirm all your findings. It is not a UI issue, the
wrong values come out of the rendering of the filter response, which is
generated on-demand for the UI.
According to my notes, the following presets show the various flavours
of this behaviour quite clearly. All those have in common that the
first effect is an EQ, which means the effect can be observed immediately
after loading, and before any interaction took place
Will Godfrey Collection
12 simple Square
70, 71... bright Rushes ....
75 Breathy Pad
92 Eeoow
107 Smooth Guitar
108 Nylon Guitar
109 Tunel Piano
118 Soft Choir
119 Full Choir
Will Godfrey Companion
4 Muffled Bells
16 Soft Metal
60 stopped pipe
Especially interesting:
107 Smooth Guitar
here Band-1 is "Off", yet still a curve is shown
which looks as if it could be the curve for Band-2 (a LP2)
Notably there is an Hysteresis, i.e. the setting lags behind
the control value
119 Full Choir
uses a Notch, which very obviously is placed on the wrong
point on the axis initially
16 Soft Metal
same as Smooth Guitar: Band-1 is off but seems to show Band-2
Those seem to imply that there might be some kind of carry-on state
be hidden in the numerics.
-- Hermann
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
