Hi Will,
Hi Kristian,
to bring that effort ahead, I just consolidated my branch
and looked into integrating the results of this discussion.
- changed the Zyn compatibility version to 2.4.3
- simplified the versioning check as proposed by Kristian,
so stick to "semantic versioning"
Furthermore, I also attempted to remove the automatic saving.
However, at that point I discovered the same thing Will noticed:
On 01.06.25 15:21, Will Godfrey wrote:
What *would* be annoying for anyone would be the same warning being
repeated on every startup, so is there a way we can ensure that this
only happens once on version changes.
And that will happen, if we do *not* re-save the migrated config.
Unless we'll introduce yet another (persistent) flag -- and IMHO then we'd
definitively do something convoluted to address hypothetical problems,
while on the other hand we are "robust" enough just to happily save
the whole config whenever a user touches some button.
For that reason I backed out and left this one as it was
in my previous proposal.
Thus the resulting behaviour is now...
Bump of revision or minor
-> do nothing
Bump of major
-> save config to migrate and give a notice message
Load of any major / minor that lies *in the future*
-> do *not* save, give a warning (and thus on every load again,
until the user really changes anything)
IMHO this seems like a good compromise,
and the logic in the code is simple again.
Any further points to discuss? Any further Bugs?
Are we ready for a pull request? (I think so)
-- Hermann
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
