On Wed, 17 Jun 2015 17:57:11 +0200
Lorenzo Sutton <[email protected]> wrote:

> 
> 
> On 17/06/2015 17:39, Will Godfrey wrote:
> > On Tue, 16 Jun 2015 23:57:50 +0200
> > Lorenzo Sutton <[email protected]> wrote:
> >
> >> On 16/06/15 23:38, Will Godfrey wrote:
> >>> On Tue, 16 Jun 2015 23:19:40 +0200
> >>> Lorenzo Sutton <[email protected]> wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> What's the expected behaviour when saving state for the system effects?
> >>>> Should they also be saved and then reloaded upon load (this is what I
> >>>> would expect)? If this is the case it doesn't seem to work as expected
> >>>> in 1.3.5.
> >>>>
> >>>> With a state saved (in 1.3.5) the effect seems to be 'there' but not
> >>>> activated. For example add a reverb, selet a preset (e.g. Hall 1) set
> >>>> some easily recognisable parameter (e.g. Damp all the way up), save
> >>>> state, close yoshimi, open reload the state. No reverb, BUT, select
> >>>> reverb and the preset and parameters are restored.
> >>>>
> >>>> Lorenzo.
> >>>
> >>> You are quite right, this is a bug, and it goes back at least to V 
> >>> 0.060.12
> >>> Can you file a bug report in sourceforge for me, and I'll start 
> >>> investigating
> >>> as soon as possible.
> >>
> >> Done: https://sourceforge.net/p/yoshimi/bugs/17/
> >>
> >>>
> >>> I had hoped we'd seen the last of these ancient, shuffling cockroaches :(
> >>>
> >> The good thing is that the effect seems to 'be there' in the state file..
> >>
> >> And thanks for such a quick reaction :)
> >>
> >> Lorenzo.
> >
> > OK, this is not quite as bad as it first looked. It is actually a GUI update
> > issue. The data is correctly loaded and initialised. A temporary work-round 
> > is
> > to change the effect number (spinbox) up then down again. Do the same the 
> > Insert
> > Effects, and finally, the same for the Part number.
> 
> It did seem something rather trivial. :-)
> >
> > Also, if you launch with --state={filename} it loads correctly.
> >
> > I'll get onto this as soon as possible, for a propper fix.
> >
> 
> Great thanks!!
> Lorenzo.

Patch attached :)

As quite a lot of things (just about everything) can be changed by a state load
I thought it valid to do a complete refresh of the main window, instead of just
updating the instrument label.

At the same time I found another minor anomaly in the same area so that is fixed
too.

-- 
Will J Godfrey
http://www.musically.me.uk
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.

Attachment: YoshiGuiPatch
Description: Binary data

------------------------------------------------------------------------------
_______________________________________________
yoshimi-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/yoshimi-user

Reply via email to