Michael Stenner wrote:
On Thu, Dec 07, 2006 at 07:01:17PM -0500, James Bowes wrote:
Please do send me what you have. I'll see if I can get it to blow up as
well.
James, are you sure the ssl patch ever actually worked? I'm seeing
lots of things that just seem wrong to me. Here are a few examples:
Yeah, it definitely works, however...
keepalive.py: calls to _get_https_connection
sslfactory.py: only _create_https_connection is defined
sslfactory.py: httpslib is imported but only httplib is ever used
at no point does the HTTPSHandler defined in m2urllib2.py ever get
used
It sounds like I just totally screwed up the keepalive stuff :/
Attached is a simple patch for the obvious stuff; I'll have to look into
this a lot more.
-James
? ssl-ug.diff
? urlgrabber/.keepalive.py.swp
Index: urlgrabber/keepalive.py
===================================================================
RCS file: /cvsroot/urlgrabber/cvs-root/urlgrabber/urlgrabber/keepalive.py,v
retrieving revision 1.16
diff -u -r1.16 keepalive.py
--- urlgrabber/keepalive.py 22 Sep 2006 00:58:05 -0000 1.16
+++ urlgrabber/keepalive.py 17 Dec 2006 20:58:41 -0000
@@ -347,7 +347,7 @@
return self.do_open(req)
def _get_connection(self, host):
- return self._ssl_factory.get_https_connection(host)
+ return self._ssl_factory.create_https_connection(host)
class HTTPResponse(httplib.HTTPResponse):
# we need to subclass HTTPResponse in order to
Index: urlgrabber/sslfactory.py
===================================================================
RCS file: /cvsroot/urlgrabber/cvs-root/urlgrabber/urlgrabber/sslfactory.py,v
retrieving revision 1.1
diff -u -r1.1 sslfactory.py
--- urlgrabber/sslfactory.py 22 Sep 2006 00:58:05 -0000 1.1
+++ urlgrabber/sslfactory.py 17 Dec 2006 20:58:41 -0000
@@ -54,7 +54,7 @@
return ssl_context
def create_https_connection(self, host, response_class = None):
- connection = httplib.HTTPSConnection(host, self.ssl_context)
+ connection = httpslib.HTTPSConnection(host, self.ssl_context)
if response_class:
connection.response_class = response_class
return connection
_______________________________________________
Yum-devel mailing list
[email protected]
https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
