James Bowes wrote:
Hi Florian:
Florian Festi wrote:
Current yum-metadata-parser creates the pre column in the requires table
but does not fill it with data (defaults to FALSE).
Nice find, and nice patch.
A few nitpicks:
* could you use gbooleans instead of setting chars to 0 and 1?
* is there any way to make it more obvious what's happening with the
INSERT INTO code?
Also, what about having a yum_db_requirement_write instead of adding
another parameter to yum_db_dependency_write?
In fact I had all that, but my patch was running unreasonably slow
(approximatly factor 8). So I removed them on the search for the problem
which turned out to be sqlite which really doesn't like booleans.
yum_db_requirement_write would be a lot of copied code and it finally turned
out that the additional parameter isn't a performance problem nor does it
make everything outside of the function more complicated.
But if this is consensus I'll be happy to post an adjusted patch.
Florian
_______________________________________________
Yum-devel mailing list
[email protected]
https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
