Jeremy Katz wrote: > So rather than just hardcode a different version, the attached adds > exporting of the dbversion to yum-metadata-parser and then using that > from createrepo. Any concerns or does this look good to everyone?
Looks good. > > > ------------------------------------------------------------------------ > > --- createrepo-0.4.8/dumpMetadata.py.dbver 2007-05-15 12:13:48.000000000 > -0400 > +++ createrepo-0.4.8/dumpMetadata.py 2007-05-15 13:07:20.000000000 -0400 > @@ -769,7 +769,10 @@ > repopath = os.path.join(cmds['outputdir'], cmds['tempdir']) > > if cmds['database']: > - dbversion = '9' > + if sqlitecachec.hasattr(DBVERSION): > + dbversion = str(sqlitecachec.DBVERSION) > + else: > + dbversion = '9' > rp = sqlitecachec.RepodataParserSqlite(repopath, repoid, None) > > for (file, ftype) in workfiles: > > Do we have to do this check here? IOW, do we expect new createrepo to be used with old y-m-p? One other point: when we open the db, how about we check the version? A Errors.DbVersionMismatchError or whatever would be better than a traceback because of a missing column, eh? -James
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Yum-devel mailing list [email protected] https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
