On Wed, 2010-06-30 at 10:12 -0400, seth vidal wrote: > On Wed, 2010-06-30 at 14:04 +0000, James Antill wrote: > > output.py | 23 +++++++++++++++++------ > > 1 file changed, 17 insertions(+), 6 deletions(-) > > > > New commits: > > commit dc4c3674848f38d7c125f16f3b3f3fcbf42a1054 > > Author: James Antill <ja...@and.org> > > Date: Wed Jun 30 09:59:14 2010 -0400 > > > > Fix history addon-info, show latest transaction info when no arg. add > > _(). > > > NACK > > This is not a fix - it in fact makes things more confusing to the user. > I'm also not keen on this being patched without being ACK'd. > > > When I was writing this I thought about how it would be used - you'd > run: > yum history info first and get the tid. > Then you'd specify the tid and get the list of addon info names > then you'd specify the tid + name to get the ones you want. > > making no tid = last is going to be confusing for the user in this case > > in the rest of the history subcommands you're only ever specifying a way > to speak about a transaction or set of transactions - this is requesting > DIFFERENT types of information. > >
additional thoughts: Adding a 'last' keyword to use in lieu of a tid number is fine - but making it assume it just means that yum history addon-info last could mean: return all the files in 'last' or return the addon info 'last' for the last transaction. It's the ambiguity I'm not in love with here - especially since it doesn't make it more convenient. -sv _______________________________________________ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel
