On Fri, 2010-12-10 at 20:58 -0800, Toshio Kuratomi wrote: > This doesn't look right to me. I think what you're trying to do is take an > Exception object, find the simple repr of that object, and then use it as > either part of a log message.
Another observation: where are the unit tests? e.g. raise an exception with a non-ASCII message, and verify that sane things happen. Do the same with a pure ASCII message, etc. Do it both at a tty, and disconnected from a tty (since Python 2's stdout's behavior varies for this...) (..snip...) Upstream python insist on unit tests with every patch, and I definitely think it helps with sanity, both for the code, and the developers :) Hope this is helpful Dave _______________________________________________ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel
