On Sat, 2011-01-15 at 14:03 +0100, Pierre-Yves wrote: > On Wed, 2011-01-12 at 11:15 -0500, seth vidal wrote: > > > > --requires --level=# --output=ascii-tree|dot-tree > > There is a patch which works for > --requires --level=[#|all] --output=[text|ascii-tree|dot-tree] > and > --whatrequires --level=[#|all] --output=[text|ascii-tree|dot-tree] > > (the old --tree-requires and -tree-whatrequires are also still valid). > > I would appreciate before I try to fix the last two trees if someone > could have a look at this patch and let me know if I am doing things > correctly.
It looks fine in general, although there are a couple of minor things: 1. default_header should be inside the DotPlot class. 2. The big == 'ascii-tree' tests should be merged a lot more, as most of the code is the same. Just using dot=None, and still passing dot=dot in the ascii-tree branch should be fine. _______________________________________________ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel
