On Sun, 2011-02-13 at 16:51 +0200, Panu Matilainen wrote: > On Fri, 11 Feb 2011, James Antill wrote: > > > > Gah, another reason to hate auto_close ... ACK. > > Can you add a comment to the ts.close() calls though, saying something > > like "note all 'mi' have to be gone when we call this" or something. > > Here's an alternative approach you might find more attractive, as instead > of adding yet more cruft it: > - hides away auto_close inside a single function > - eliminates the dangling iterator issue > - removes code duplication by handling gpg-pubkey filtering centrally > - should be compatible with all historical rpm brokenness in this area
ACK, for the code. Although the indentation seems weird in a few places (Eg. _all_packages() doesn't look like it should need -+ lines). > _header_from_index() could be converted to use this too, but if it's > expected to return headers for gpg-pubkeys too then _get_packages() will > need a switch to enable/disable the filtering. That should be fine, although _header_from_index() is a dead function anyway. As long as returnGPGPubkeyPackages works, it's all good :). _______________________________________________ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel
