On Fri, 2011-10-21 at 16:28 +0200, Zdeněk Pavlas wrote: > This callback is called when urlgrab request fails. > If grab is wrapped in a mirror group, only the mirror > group issues the callback.
I've pushed everything before this. This patch looks mostly fine, however "failfunc" seems pretty bad as a name. Also having two code paths seems non-optimal, can't we have the default "failfunc" just do the raise? Finally the _callback() method could use a better name ... I guess it's "_run_callback" or "_call_callable" ... which still aren't good, but give some idea. _______________________________________________ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel
