On Wed, Jul 11, 2012 at 10:58 AM, Zdenek Pavlas <zpav...@redhat.com> wrote: > Hi, and sorry for late reply (holiday time)!
np. I just got back from a small vacation myself :) > IMO, your patch works fine with singleton repos, but the worst-case > scenario of (#mirrors * #retries) retries needs to be changed. > Because the replication of metadata and repomd.xml to mirrors > is not atomic, Yum may (and does, sometimes) attempt to retrieve > URLs that 404 on *every* mirror. Sure, I can adjust the patch to use a per-request total rather that per-request-per-mirror. However, that would effectively truncate long mirror lists. I'm thinking the number of retries per request should be: max(retries, min(max_mirrors, len(mirrors))) where max_mirrors is a new configuration option. >> Note that even in the current patch the retry might not be immediate. >> Yum will try all the mirrors before retrying any of them. Unless all >> the mirrors fail, there will be no retries of earlier failing >> mirrors. > > + if tries == self.retries: > + action['remove_master'] = action['remove'] = 1 > > The 'remove_master' kills the mirror for good. I'm sure we > don't want that, esp. for 404s. That was deliberate. The tries value in that patch was the number of sequential failures for the mirror in question. However, it's not really much of a gain with mirror increments on every failure. I'll remote it in the next patch. _______________________________________________ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel
