On Wed, 2012-08-01 at 06:10 -0400, Zdenek Pavlas wrote:
> No problems in general use, and the comps file got uncompressed.
> 
> >              # 2. Download a .xml.gz and convert to .xml.gz.sqlite
> >              base.repos.populateSack(mdtype='all', cacheonly=1)
> >  
> > +            # These are covered by the popSack above.
> > +            main_MD_types = set(['primary', 'primary_db',
> > +                                 'filelists', 'filelists_db',
> > +                                 'other', 'other_db'])
> > +            for repo in base.repos.listEnabled():
> > +                    ...
> > +                    repo.retrieveMD(MD)
> 
> The extra download step seems unnecessary.  I've noticed we already
> download group_gz, updateinfo and prestodelta.  That's because 
> when repo.mdpolicy == "group:all", doSetup() downloads all 
> repo.retrieved.keys().

 Yeh, I was mostly being stupid. I was thinking if the metalink matches
then the repomd doesn't get updated, and we don't do the group:all code
paths ... but checking shows that's not the case, so the above is all
noops. Rm'd.

> yum/yumRepo.py:
>         self.retrieved = { 'primary':0, 'filelists':0, 'other':0, 'group':0,
>                            'updateinfo':0, 'prestodelta' : 0}
> 
> I'd just add "pkgtags" here to download it too.

 I updated the download code so that group:all also includes all the
types from the repomd (including anything not listed above).

_______________________________________________
Yum-devel mailing list
[email protected]
http://lists.baseurl.org/mailman/listinfo/yum-devel

Reply via email to