On Mon, 2012-08-27 at 11:29 -0400, Zdenek Pavlas wrote: > > (~15MB now) takes about a minute. Having zero UI updates for an > > entire minute, just because updateinfo/group is still broken would be a > > massive UI fail. > > It does update, just the (initial) total size is wrong (should be bigger, > since unknown counts as zero), so the progress bar is somewhat 'ahead'. > Once the unknown-size file is finished, we update to total so it's 'fixed'.
We can't/shouldn't show percentages/progress-bar if we don't have the total size. Doing that means that the progress bar stops for unknown (to any sane user) reasons with the degenerate case being we get to 100% and stay there, which they are guaranteed to notice and open bugs about. The alternative is to have the percentage goto 250% or whatever (and the progress bar will still be "stuck"), and that will also cause unhappiness/BZs. That's why I split it at the yum layer, there didn't seem to be a reasonable way to deal with a mix at the urlgrabber layer. > > On a related note I've noticed that the "total progress" number > > doesn't seem to be going up until an entire file is download now .. > > is this intentional, if so why? > > Yes, the percentages do not reflect in-progress files, it also ignores > file sizes- just #finished/#total. That's the part I didn't touch, > seemed intentional to me. > > commit 40914491ab88c5ec7604b7e2184f009530c300ed > Author: mstenner <mstenner> > Date: Thu Jul 22 03:04:22 2004 +0000 > + df = self.finished_files > + tf = self.numfiles > + pf = 100 * float(df)/tf + 0.49 Ahh, that was a missed fix in d09bda90f15eee161a17944428e9bec0bfc812b6, for the old UI. Want me to send a patch, or you want to just do it? > > so we download just primary and then group/updateinfo if we "need" > > those. However, AFAIK nothing adds those to mdpolicy, yet (or > > deltainfo). So the only thing we download is primary anyway, which > > has size information. > > Have you changed mdpolicy in your config? > > No, the 10 files with size, 20 without size case was 'yum makecache' > with empty /var/cache/yum, with a bunch of non-fedora repos enabled. Ahh, makecache, yeh. But that should be a edge case, esp. for user interactive usage of it. Also ... 20 without size? Do some of your repos. have no size information on any files? _______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
