> Might want to name the option something more generic at this point, > like "deltas" or "deltarebuild" or something.
"deltas" is probably too generic. I'd use "deltarpm" to enable download and rebuild from .drpms, and "deltamd" to enable delta metadata (tbd). > > + def to_drpm(self, po): > > This is pretty magic, and it seems like a bad idea to convert the > package into a special delta-package do the download/verify/rebuild > and then convert it back. I wanted to reuse getPackage() and verifyLocal(). Could probably do the same by creating a fresh PackageObject instance with drpm attributes, and store the original po in ._rpm attribute... will think about this. > Also why give to_rpm a return value ... just so we can put it in the > if statement? I didn't need it. > Along with 1/5 patch ... what does this do on file:// repos? I assume > the first cleanup patch didn't break it, but we still create the > .rpms from the .drpms here and thus. break copy_local? I don't check or rewrite URLs in any way, and applydelta is called with po.localpath arguments, hence file:// is stripped.. should work, IMO. > I'm probably just being stupid, but I don't see how pkg.rebuild() is > being called when not in --downloadonly mode. po.rebuild() is called at two places: 1) explicitly when there's .drpm ready, 2) from .drpm DL checkfunc. Both is --downloadonly independent. When enabled, we just rebuild from foo.drpm.$pid.tmp to foo.rpm.$pid.tmp and rename to foo.rpm at the end. Tried a full "yum update" with drpms on, and it worked. _______________________________________________ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel
