On Wed, 2013-12-04 at 13:41 +0100, Mathieu Chouquet-Stringer wrote:
> Hello,
>
> As a user of btrfs, I've been using the fs-snapshot plugin for a while.
> I discovered snapper (http://snapper.io/) a while ago now and started
> looking at how it could be used with the fs-snapshot plugin. FYI snapper
> is already available as a package in Fedora.
[...]
> I've created a quick and dirty patch for fs-snapshot which adds a
> use_snapper option to the plugin. When enabled (it's disabled by
> default), instead of using the native btrfs tool to create snaps, it
> uses snapper (in pre and post).
>
> Is this something people could be interested in? Could it be merged as
> such (after some polishing) or should I rather target dnf?
There is snapshot support in yum now, although it uses only the LVM
APIs currently. Adding support for snapper is desired there and probably
within the plugin too.
I'll wait for the authors of the plugin to comment before doing
anything, but from a looks only POV if you could change the patch so
that it doesn't have the else clause then it'll be less indented (more
readable) and all the old lines will be unchanged ("git blame" will
still work, etc.). Also can you use snapper for the LVM bits? If not
it's probably better to make that obvious in some way (Eg. not a generic
"use_snapper" top level config.).
_______________________________________________
Yum-devel mailing list
Yum-devel@lists.baseurl.org
http://lists.baseurl.org/mailman/listinfo/yum-devel
