On Tue, 2010-04-06 at 17:16 -0400, Dmitriy Kargapolov wrote:
> Hi all,
> I found non-critical bug in the sippacket.erl, see the fix below.
> This bug resulted in parser error when quoted display name contains
> <TAB> character.
> Something like this:
> 
> Error in process <0.23778.188> on node '<nodename>' with exit value:
> {{caught_error,{badmatch,{unparseable,{unquoted_displayname_is_not_a_valid_token,"Firstname
>        
> Lastname\""}}},[{sipheader,get_tag,1},{siprequest,get_loop_cookie,3},{sipserver,check_for_loop,3},{sipserver,process_parsed_packet...
> 
> The following patch should fix the problem:
> 
> --- sippacket.erl     (revision 4212)
> +++ sippacket.erl     (working copy)
> @@ -340,7 +340,7 @@
> 
>  parse_one_header_values2(Bin, Comma, Offset, StartOffset, Len, Res) ->
>      case Bin of
> -     <<_:Offset/binary, N:8, _/binary>> when Len == 0, Res == [], N ==
> ?SP; N == ?HTAB ->
> +     <<_:Offset/binary, N:8, _/binary>> when Len == 0, Res == [], N ==
> ?SP orelse N == ?HTAB ->
>           %% space / tab after colon, just ignore
>           parse_one_header_values2(Bin, Comma, Offset + 1, StartOffset +
> 1, Len, Res);
>       <<_:Offset/binary, ?CR, ?LF, N:8, _/binary>> when N == ?SP; N == ?HTAB 
> ->

The patch looks good, and even makes the code match the comment =).

May I ask that you fork yxa in github, add a test case and send me a
pull request?

/Fredrik


_______________________________________________
Yxa-devel mailing list
Yxa-devel@lists.su.se
https://lists.su.se/mailman/listinfo/yxa-devel

Reply via email to