Hi!

> > I think you want to hold the mutex at the point you setup the data to be
> > transferred, do the transfer, and then release the mutex once you've read
> > the results of the transfer.
> 
> oh no, not again...
> this was the earliest version, not the cleaned-up one (notice the lock in 
> setup-transfer, which I said was unnecessary)
> here is the cleaner (newest) version:

Unfortunately that one does not apply, due to 

> @@ -213,6 +224,7 @@ static int __devexit max1111_remove(struct spi_device 
> *spi)

Whitespace damage. (but if you just delete this extra newline, its
fine).

Other than that, it seems to work. I was playing with max1111 a lot
today, and no oops.

ACK.
                                                                        Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

_______________________________________________
Zaurus-devel mailing list
Zaurus-devel@lists.linuxtogo.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/zaurus-devel

Reply via email to