On Thu, May 04, 2006 at 12:06:24AM +0100, Daniel Drake wrote:
> Greg KH wrote:
> >Also, I couldn't think of a better
> >name for the vendor id, if you can, please do (this device says it is a
> >ZyDAS device, yet another vendor id, yeah, fun...)
> 
> I'm not sure we'll keep with the vendor name #defines - I think Ulrich 
> pulled them from the vendor driver originally? We have a much more 
> detailed list at http://zd1211.ath.cx anyhow.
> 
> I renamed your addition to VENDOR_TRENDNET for now, as we've been using 
> retail brand names so far...

Yes, that makes much more sense.

> >Also, in looking at the debugging macros, does anyone mind if I rework
> >them a bit to use the standard kernel message formats?  I mean the
> >dev_dbg(), dev_err(), and such.  It provides a common format, and makes
> >it much easier to determine exactly what driver and device is spitting
> >out the messages to the kernel log.
> 
> Sounds good to me.

Hm, what is the meaning of the following macros:
        PDEBUGG()
        PDEBUGFG()
        LPDEBUGFG()
?

Can I just drop them entirely?

thanks,

greg k-h


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Zd1211-devs mailing list - http://zd1211.ath.cx/
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/zd1211-devs

Reply via email to