Ok on it. I propose releasing 0.8 without those modifications so we can test it during the 0.9 development cycle if you don't mind
On Mon, Mar 14, 2011 at 10:36 AM, Mikkel Kamstrup Erlandsen < mikkel.kamst...@gmail.com> wrote: > Awesome work Seif! > > I agree with Siegfried; > > - I think the engine should enforce - on everything but MoveEvents - that > uri==current_uri. Then, like you did for datamodel.py, the client side libs > will help app authors get this right. > > - it should be current_uri, not uri_current. We don't use reverse polish > notation in the Zeitgeist codebase. > > Other nitpicks: > > - Can you also add a hook for DeleteEvents like you have with MoveEvent? > Lest we don't forget :-) > > -- > https://code.launchpad.net/~zeitgeist/zeitgeist/move-event/+merge/53132 > You are subscribed to branch lp:zeitgeist. > -- This is me doing some advertisement for my blog http://seilo.geekyogre.com https://code.launchpad.net/~zeitgeist/zeitgeist/move-event/+merge/53132 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/dbschema4. _______________________________________________ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
