On Wed, May 11, 2011 at 04:04:01PM -0000, Siegfried Gevatter wrote:
> Thanks, I've committed your fix.
> Can you please check if it's working right (since I applied the chnges by 
> hand):
> http://bazaar.launchpad.net/~zeitgeist-dataproviders/zeitgeist-dataproviders/trunk/view/head:/emacs/zeitgeist.el

Thanks - looks good to me.


You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to Zeitgeist Data-Sources.

  emacs data-provider should handle dbus errors

Status in Zeitgeist Data-Providers:
  Fix Committed

Bug description:
  My screen-based emacs's DBUS_SESSION_BUS_ADDRESS environment variable
  got superceded, and though emacs was fine and could open frames in the
  new session, it was very naughty about opening, saving, and closing
  files/buffers because the dbus-call-method in zeitgeist.el was

  This patch reduces the annoyance a bit:

  --- emacs/zeitgeist.el  2011-05-04 18:57:00 +0000
  +++ emacs/zeitgeist.el  2011-05-09 09:59:08 +0000
  @@ -26,12 +26,14 @@
   (defun zeitgeist-call (method &rest args)
     "Call the zeitgeist method METHOD with ARGS over dbus"
  -  (apply 'dbus-call-method
  -        :session                            ; use the session (not system) 
  -        "org.gnome.zeitgeist.Engine"        ; service name
  -        "/org/gnome/zeitgeist/log/activity" ; path name
  -        "org.gnome.zeitgeist.Log"           ; interface name
  -        method args))
  +  (condition-case err
  +      (apply 'dbus-call-method
  +             :session                            ; use the session (not 
system) bus
  +             "org.gnome.zeitgeist.Engine"        ; service name
  +             "/org/gnome/zeitgeist/log/activity" ; path name
  +             "org.gnome.zeitgeist.Log"           ; interface name
  +             method args))
  +  (dbus-error (message (format "zeitgeist-call %s failed due to D-Bus error 
%s" method err))))
   (defun zeitgeist-event-timestamp ()
     "Get the timestamp in zeitgeist format."

Mailing list: https://launchpad.net/~zeitgeist
Post to     : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Reply via email to