Review: Approve
Sure, feel free add the other enums and push.

Some stupid nitpicking like usual:

I'd limit lines to max. 80 characters each, ie. here writing it like:

// comment
// ... more comment
MostRecentEvents,

Or maybe:

MostRecentEvents   // comment
                   // ... more comment

(But in the later case I'd have all comments intented to start at the same 
column so it looks nice.)

Also you're removing a valid intentation newline before the closing "}" of the 
Event class (diff line 57).
-- 
https://code.launchpad.net/~seif/zeitgeist/bluebird-enums/+merge/69344
Your team Zeitgeist Framework Team is subscribed to branch 
lp:~zeitgeist/zeitgeist/bluebird.

_______________________________________________
Mailing list: https://launchpad.net/~zeitgeist
Post to     : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Reply via email to