Lovely :).

Pedantic comments:

 - If you modified query_timings.py, copyright's missing in there.
 - Return extra_data to something else (eg. result), since it's not just "extra 
data", but all the data :P.
 - Typo: "running and instance of", "argument, multible '--plot' arguments", 
"zeitgeist" (capitalize), "several types of plots ??such?? using", 
"find_events, overall)" -> "find_events or overall", "will define multible 
series." (where does this sentence start? also multiple typo again).
 - tools/development/benchmark.py: Not sure, but I'd replace the numbers with 
proper constants from zeitgeist.datamodel. You can then also use 
ZeitgeistClient.get_extension.
 - benchmark.py seems pretty arbitrary.
 - Seriously there isn't a good enough plot library in Python or Debian 
repository?
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/benchmark-tools/+merge/86867
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

_______________________________________________
Mailing list: https://launchpad.net/~zeitgeist
Post to     : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Reply via email to